store/tikv: support injecting customized failure to prewrite #23432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
ti-chi-bot
added
the
needs-rebase
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
custom-prewrite-failure
branch
from
4669f18 to
afa4740
Compare
MyonKeminta
approved these changes
Apr 14, 2021
ti-chi-bot
added
status/LGT1
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 23bf3e7
|
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Apr 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #24036 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
We have only
prewritePrimaryFailandprewriteSecondaryFailfailpoints for prewrite. If we trigger these failpoints, the transaction fails. Sometimes we just need a pause or a sleep to control the sequential timings without breaking the transaction.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note