Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: forward requests by BatchCommands (#23243) #23420

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 18, 2021

cherry-pick #23243 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23420

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23420:release-5.0-3813da0140e0

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Problem Summary:

Support forwarding requests by BatchCommands. Based on #23362.

What is changed and how it works?

What's Changed:

Create a BatchCommands for each forwarded host in a single connection.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/tikv sig/transaction SIG:Transaction size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.0-cherry-pick labels Mar 18, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 18, 2021
@ti-srebot
Copy link
Contributor Author

@youjiali1995 you're already a collaborator in bot's repo.

@youjiali1995
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@MyonKeminta: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2021
@youjiali1995
Copy link
Contributor

[2021-03-19T10:01:44.322Z] ----------------------------------------------------------------------
[2021-03-19T10:01:44.322Z] FAIL: simple_test.go:606: testSuite3.TestDropPartitionStats
[2021-03-19T10:01:44.322Z] 
[2021-03-19T10:01:44.322Z] simple_test.go:631:
[2021-03-19T10:01:44.322Z]     tk.MustExec("analyze table t")
[2021-03-19T10:01:44.322Z] /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:217:
[2021-03-19T10:01:44.322Z]     tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
[2021-03-19T10:01:44.322Z] ... value *errors.withStack = [stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table ("[stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table")
[2021-03-19T10:01:44.322Z] ... sql:analyze table t, [], error stack [stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table
[2021-03-19T10:01:44.322Z] github.com/pingcap/errors.AddStack
[2021-03-19T10:01:44.322Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20201126102027-b0a155152ca3/errors.go:174
[2021-03-19T10:01:44.322Z] github.com/pingcap/errors.Trace
[2021-03-19T10:01:44.322Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20201126102027-b0a155152ca3/juju_adaptor.go:15
[2021-03-19T10:01:44.322Z] github.com/pingcap/tidb/util/testkit.(*TestKit).Exec
[2021-03-19T10:01:44.322Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:176
[2021-03-19T10:01:44.322Z] github.com/pingcap/tidb/util/testkit.(*TestKit).MustExec
[2021-03-19T10:01:44.323Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:216
[2021-03-19T10:01:44.323Z] github.com/pingcap/tidb/executor_test.(*testSuite3).TestDropPartitionStats
[2021-03-19T10:01:44.323Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/simple_test.go:631
[2021-03-19T10:01:44.323Z] reflect.Value.call
[2021-03-19T10:01:44.323Z] 	/usr/local/go/src/reflect/value.go:460
[2021-03-19T10:01:44.323Z] reflect.Value.Call
[2021-03-19T10:01:44.323Z] 	/usr/local/go/src/reflect/value.go:321
[2021-03-19T10:01:44.323Z] github.com/pingcap/check.(*suiteRunner).forkTest.func1
[2021-03-19T10:01:44.323Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850
[2021-03-19T10:01:44.323Z] github.com/pingcap/check.(*suiteRunner).forkCall.func1
[2021-03-19T10:01:44.323Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739
[2021-03-19T10:01:44.323Z] runtime.goexit
[2021-03-19T10:01:44.323Z] 	/usr/local/go/src/runtime/asm_amd64.s:1357

@youjiali1995
Copy link
Contributor

/run-unit-test

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 19, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d224dd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2021
@ti-chi-bot ti-chi-bot merged commit 9ed4abb into pingcap:release-5.0 Mar 19, 2021
@youjiali1995 youjiali1995 deleted the release-5.0-3813da0140e0 branch March 19, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv sig/transaction SIG:Transaction size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants