Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: delay before changing column from null to not null #23364

Merged
merged 13 commits into from
Mar 19, 2021
Merged

ddl: delay before changing column from null to not null #23364

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
105a8a2
ddl: delay before changing column from null to not null
sticnarf Mar 17, 2021
597064f
Merge branch 'master' into delay-before-not-null
sticnarf Mar 17, 2021
383e6ea
address comment: make log more accurate
sticnarf Mar 17, 2021
9bd964a
Merge branch 'delay-before-not-null' of https://github.com/sticnarf/t…
sticnarf Mar 17, 2021
0b0492d
Merge remote-tracking branch 'upstream/master' into delay-before-not-…
sticnarf Mar 17, 2021
ab9f8cb
Merge branch 'master' into delay-before-not-null
ti-chi-bot Mar 18, 2021
57659f2
Merge remote-tracking branch 'upstream/master' into delay-before-not-…
sticnarf Mar 18, 2021
e507de6
do not modify go.sum
sticnarf Mar 18, 2021
eb0d88a
Merge branch 'master' into delay-before-not-null
ti-chi-bot Mar 18, 2021
855dade
Merge branch 'master' into delay-before-not-null
AilinKid Mar 18, 2021
4be762b
Merge branch 'master' into delay-before-not-null
ti-chi-bot Mar 18, 2021
2a81dab
Merge branch 'master' into delay-before-not-null
ti-chi-bot Mar 18, 2021
57e13ea
Merge branch 'master' into delay-before-not-null
ti-chi-bot Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment: make log more accurate 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
  • Loading branch information
@sticnarf
sticnarf committed Mar 17, 2021
commit 383e6ea79766b50451afc52d5a63a51f997a03ba
2 changes: 1 addition & 1 deletion ddl/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ type RecoverInfo struct {
func delayForAsyncCommit() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check 1PC here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1PC works in the same way with async commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sleep before DDL finishes to make async commit safe" is not accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I just change the log without changing the function name. It looks too verbose to also put 1PC to the name

cfg := config.GetGlobalConfig().TiKVClient.AsyncCommit
duration := cfg.SafeWindow + cfg.AllowedClockDrift
logutil.BgLogger().Info("sleep before DDL finishes to make async commit safe",
logutil.BgLogger().Info("sleep before DDL finishes to make async commit and 1PC safe",
zap.Duration("duration", duration))
time.Sleep(duration)
}
Expand Down