Skip to content

Revert "*: upgrade go version to 1.16 (#22895)" #22906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2021
Merged

Revert "*: upgrade go version to 1.16 (#22895)" #22906

merged 2 commits into from
Feb 24, 2021

Conversation

disksing
Copy link
Contributor

This reverts commit ae46cda.

What problem does this PR solve?

Upgrading Go version is risky.

What is changed and how it works?

What's Changed:

  • revert to go1.13

Related changes

#22895

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2021
@disksing
Copy link
Contributor Author

/run-all-tests

@morgo
Copy link
Contributor

morgo commented Feb 24, 2021

I think it's important to note that 1.13 is no longer receiving security fixes! See: https://golang.org/doc/devel/release.html#policy

Go's support lifecycle is even shorter than I expected. So it's totally possible that in order to support TiDB for 3 years, we will need to maintain our own golang builds :(

@disksing
Copy link
Contributor Author

I think it's important to note that 1.13 is no longer receiving security fixes! See: https://golang.org/doc/devel/release.html#policy

Go's support lifecycle is even shorter than I expected. So it's totally possible that in order to support TiDB for 3 years, we will need to maintain our own golang builds :(

That's really a fresh perspective! But I don't think they want to use go1.13 forever. As I was told, we need to come up with a standard procedure and a well-established checklist. Then we could be more confident to upgrade.

zz-jason
zz-jason reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

zz-jason
zz-jason reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2021
@disksing
Copy link
Contributor Author

/assign @pingcap/tidb-committer

AndreMouche
AndreMouche approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@AndreMouche: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78bd7b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78bd7b4

@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@disksing
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit dd5457f into pingcap:master Feb 24, 2021
@disksing disksing deleted the go1.13 branch February 24, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disksing @morgo @ti-chi-bot @AndreMouche @zz-jason