ddl, session: add tidb_enable_exchange_partition variable #22638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
label component/session |
|
label sig/DDL |
|
/label component/session, sig/DDL |
|
/cc @qw4990 |
|
@rebelice SIG-DDL is renamed to SIG-SQL-INFRA. So you do not need to label sig/ddl. It is sig/infra now. |
xhebox
reviewed
Feb 2, 2021
| @@ -273,4 +273,6 @@ var ( | |||
|
|
|||
| // ErrUnknownEngine is returned when the table engine is unknown. | |||
| ErrUnknownEngine = dbterror.ClassDDL.NewStd(mysql.ErrUnknownStorageEngine) | |||
|
|
|||
| errExchangePartitionDisabled = dbterror.ClassDDL.NewStdErr(mysql.ErrUnsupportedDDLOperation, parser_mysql.Message("Exchange Partition is disabled, please set 'tidb_enable_exchange_partition' if you need to need to enable it", nil)) | |||
There was a problem hiding this comment.
Is it indented to use errExchangePartitionDisabled? Why not the exported Err?
There was a problem hiding this comment.
Because it will only be used in the current package, just like errTablePartitionDisabled, so I don’t think it needs to be exported.
|
/unlabel sig/ddl |
|
/label sig/infra |
ti-srebot
approved these changes
Feb 3, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 3, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0-rc in PR #22706 |
ti-srebot
added a commit
that referenced
this pull request
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
Add tidb_enable_exchange_partition variable to enable or disable exchange partition.
Disabled by default.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note