Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcworker: disable green GC (#22533) #22595

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 28, 2021

cherry-pick #22533 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22595

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22595:release-5.0-rc-9390c5053b3e

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

There is another corner case that isn't solved: tikv/tikv#8184 (comment), so disable it for now.

What is changed and how it works?

What's Changed:
Disable green GC by default.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • Disable green GC by default.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@youjiali1995 you're already a collaborator in bot's repo.

@bb7133
Copy link
Member

bb7133 commented Feb 4, 2021

Close it since only the following PRs are required to cherry-pick to 5.0-rc:

  • critical bug-fixs
  • required feature changes
  • PRs to stabilize CI

@bb7133 bb7133 closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants