gcworker: skip GC if the safe point isn't changed #22482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
added
type/bugfix
Closed
MyonKeminta
approved these changes
Jan 22, 2021
ti-srebot
approved these changes
Jan 25, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
sticnarf
reviewed
Jan 25, 2021
| @@ -324,7 +324,7 @@ func (w *GCWorker) checkPrepare(ctx context.Context) (bool, uint64, error) { | |||
| if err != nil || !ok { | |||
| return false, 0, errors.Trace(err) | |||
| } | |||
| newSafePoint, newSafePointValue, err := w.calculateNewSafePoint(ctx, now) | |||
| newSafePoint, newSafePointValue, err := w.calcNewSafePoint(ctx, now) | |||
There was a problem hiding this comment.
This new safe point is saved before locks are resolved. Then, if we fail to resolve locks and we don't advance the global min start ts, GC will not retry.
There was a problem hiding this comment.
How about saving it after GC is done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #15007 #16602
Problem Summary:
skip GC if the safe point isn't changed
What is changed and how it works?
What's Changed:
skip GC if the safe point isn't changed
Related changes
Check List
Tests
Release note