store/tikv: set short pessimistic lock TTL through failpoints #22431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
MyonKeminta
reviewed
Jan 20, 2021
store/tikv/2pc.go
Outdated
| logutil.BgLogger().Info("[failpoint] injected failure at running ttlManager", | ||
| zap.Uint64("txnStartTS", c.startTS)) | ||
| failpoint.Return() | ||
| }) |
There was a problem hiding this comment.
Is this redundant with doNotKeepAlive in this pr?
There was a problem hiding this comment.
Ah, yes. We should do these things in serial.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
MyonKeminta
approved these changes
Jan 21, 2021
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Jan 21, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sticnarf merge failed. |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Make it possible to set short TTL for pessimistic locks and skip running TTL manager. It helps tests (for example tikv/tikv#9523).
Check List
Tests
Release note
No release note