-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: reorder inner joins simplified from outer joins (#22392) #22403
planner: reorder inner joins simplified from outer joins (#22392) #22403
Conversation
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
402490b
to
211231e
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close it since only the following PRs are required to cherry-pick to 5.0-rc:
|
cherry-pick #22392 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22403
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22384
Problem Summary:
Plan for query containing outer join is not optimal.
What is changed and how it works?
What's Changed:
Add
flagJoinReOrder
when buildingLogicalJoin
regardless of the join types.joinReorderSolver
itself can check if the reorder is applicable.How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note