Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: reorder inner joins simplified from outer joins (#22392) #22403

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 15, 2021

cherry-pick #22392 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22403

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22403:release-5.0-rc-dd5bfc39490e

What problem does this PR solve?

Issue Number: close #22384

Problem Summary:

Plan for query containing outer join is not optimal.

What is changed and how it works?

What's Changed:

Add flagJoinReOrder when building LogicalJoin regardless of the join types. joinReorderSolver itself can check if the reorder is applicable.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Reorder inner joins simplified from outer joins

@ti-srebot ti-srebot requested a review from a team as a code owner January 15, 2021 04:02
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team January 15, 2021 04:02
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@eurekaka
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2021
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2021
@bb7133
Copy link
Member

bb7133 commented Feb 4, 2021

Close it since only the following PRs are required to cherry-pick to 5.0-rc:

  • critical bug-fixs
  • required feature changes
  • PRs to stabilize CI

@bb7133 bb7133 closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants