planner/core: push selection operator to mpp task #22343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
approved these changes
Jan 11, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
fzhedu
reviewed
Jan 11, 2021
| if mppTask, _ := tasks[0].(*mppTask); mppTask != nil { // always push to mpp task. | ||
| sc := sel.ctx.GetSessionVars().StmtCtx | ||
| if expression.CanExprsPushDown(sc, sel.Conditions, sel.ctx.GetClient(), kv.TiFlash) { | ||
| return attachPlan2Task(sel, mppTask.copy()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
In TiDB, selection can not appear above a operator except table scan. But in Mpp mode, that's not the case any more.
What is changed and how it works?
What's Changed:
In attack 2 task phase, selection can be attached to MPP part
Check List
Tests
Side effects
None
Release note