expression: return correct results for user variables of datetime type (#22078) #22143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/expression
type/4.0-cherry-pick
type/bugfix
|
@eurekaka you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-9cb4fb38d844
branch
from
a65518c to
d04ffbc
Compare
|
LGTM |
|
/run-unit-test |
ti-srebot
added
status/LGT2
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22078 to release-4.0
What problem does this PR solve?
Issue Number: close #22077
Problem Summary:
Incorrect results for user variables of datetime type.
What is changed and how it works?
What's Changed:
use
ToString()to convert datum from other types to string type, instead ofGetString().How it Works:
See code comments.
Related changes
Check List
Tests
Side effects
N/A
Release note