Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: check iter.Next() errors. #2198

Merged
merged 3 commits into from
Dec 8, 2016
Merged

kv: check iter.Next() errors. #2198

merged 3 commits into from
Dec 8, 2016

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 8, 2016

  1. UnionIter should not discard errors.
  2. Next() should return nil when no more keys in db.

@shenli @zimulala

shenli
shenli reviewed Dec 8, 2016
View reviewed changes
store/localstore/mvcc_test.go
@@ -42,14 +42,6 @@ func createMemStore(suffix int) kv.Storage {
return store
}

func (t *testMvccSuite) addDirtyData() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@coocood
Copy link
Member

coocood commented Dec 8, 2016

When will dirty iterator return error?

@coocood
Copy link
Member

coocood commented Dec 8, 2016

LGTM

1 similar comment
@shenli
Copy link
Member

shenli commented Dec 8, 2016

LGTM

@disksing disksing merged commit 5f53175 into master Dec 8, 2016
@disksing disksing deleted the disksing/union-iter branch December 8, 2016 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disksing @coocood @shenli