-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: throw error when prepared statement is execute, deallocate or prepare #21962
Merged
ti-srebot
merged 3 commits into
pingcap:master
from
xuyifangreeneyes:forbid-unsupported-stmt-for-prepare
Dec 23, 2020
Merged
executor: throw error when prepared statement is execute, deallocate or prepare #21962
ti-srebot
merged 3 commits into
pingcap:master
from
xuyifangreeneyes:forbid-unsupported-stmt-for-prepare
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuyifangreeneyes
requested review from
lzmhhh123
and removed request for
a team
December 23, 2020 07:35
lzmhhh123
reviewed
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
@XuHuaiyu PTAL |
XuHuaiyu
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Dec 23, 2020
ti-srebot
approved these changes
Dec 23, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 23, 2020
/run-all-tests |
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #21972 |
Tjianke
pushed a commit
to Tjianke/tidb
that referenced
this pull request
Dec 25, 2020
qw4990
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17412
Problem Summary:
TiDB regards sql like
prepare stmt1 from "execute stmt"
as valid.What is changed and how it works?
What's Changed:
When prepared statement is execute, deallocate or prepare, throw error
ERROR 1295 (HY000): This command is not supported in the prepared statement protocol yet
.Related changes
Check List
Tests
Release note