types: fix compare float64 with float64 in json #21709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
|
There is no reward for this challenge pull request, so you can request a reward from @lzmhhh123. |
|
/run-all-tests |
XuHuaiyu
reviewed
Dec 14, 2020
| @@ -647,6 +647,16 @@ func compareInt64(x int64, y int64) int { | |||
| return 1 | |||
| } | |||
|
|
|||
| func compareFloat64(x float64, y float64) int { | |||
There was a problem hiding this comment.
Can we use compareFloat64PrecisionLoss
There was a problem hiding this comment.
The origin code used it. Then got the wrong result.
|
/run-integration-copr-test |
Closed
|
PTAL @wshwsh12 |
ti-srebot
approved these changes
Dec 15, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21785 |
ti-srebot
added a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lzmhhh123 lzmhhh123@gmail.com
What problem does this PR solve?
Issue Number: close #10461
What is changed and how it works?
What's Changed: reference https://github.com/mysql/mysql-server/blob/ee4455a33b10f1b1886044322e4893f587b319ed/sql/json_dom.cc#L2656
Related changes
Check List
Tests
Release note