Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add the field of history information in job #2170

Merged
merged 5 commits into from
Dec 7, 2016
Merged

*: Add the field of history information in job #2170

merged 5 commits into from
Dec 7, 2016

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 5, 2016

Handle #1936.
This is for compatibility with previous version. So it is the first step, the second is remove the assignment to the job's arguments.

@zimulala zimulala mentioned this pull request Dec 5, 2016
Merged
@zimulala
Copy link
Contributor Author

zimulala commented Dec 5, 2016

PTAL @GregoryIan @coocood @tiancaiamao @shenli

@coocood
Copy link
Member

coocood commented Dec 7, 2016

LGTM

@shenli
Copy link
Member

shenli commented Dec 7, 2016

@GregoryIan PTAL

@IANTHEREAL
Copy link
Contributor

LGTM

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zimulala zimulala merged commit f5792b5 into master Dec 7, 2016
@zimulala zimulala deleted the zimuxia/job-binlog-compatibility branch December 7, 2016 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @coocood @shenli @IANTHEREAL @CLAassistant