planner: do not push down the aggregation function with correlated column (#21453) #21546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
sig/planner
ti-srebot
requested review from
eurekaka,
lzmhhh123,
SunRunAway and
wjhuang2016
|
@Reminiscent you're already a collaborator in bot's repo. |
|
/run-all-tests |
|
@lzmhhh123 @eurekaka PTAL |
ti-srebot
added
status/LGT2
|
/run-all-tests |
|
/run-all-tests |
zz-jason
approved these changes
Jan 25, 2021
ti-srebot
added
status/LGT3
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21453 to release-4.0
What problem does this PR solve?
Issue Number: close #21414
Problem Summary:
When an aggregation function with a correlated column pushed down, the correlated column will be incorrectly calculated as a null datum.
What is changed and how it works?
ContainCorrelatedColumnto check if the expressions contain a correlated column.ContainCorrelatedColumntoCheckAggCanPushCopto prohibit aggFunc with a correlated column pushdown.Check List
Tests
Side effects
Some aggregation executor may not be pushed down.
Release note