Revert "expression: fix a bug that DML using caseWhen may cause schema change" #21243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-all-test |
|
/run-all-tests |
|
LGTM |
|
There is no reward for this challenge pull request, so you can request a reward from @SunRunAway. |
|
/run-check_dev_2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19857
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #19387
Problem Summary:
BuildCastFunction(expr.GetCtx(), foldedExpr, foldedExpr.GetType())inconstant_fold.goin wrong and needless.foldedExpr.GetType()should beexpr.GetType().What is changed and how it works?
BuildCastFunction(expr.GetCtx(), foldedExpr, foldedExpr.GetType()).Related changes
Check List
Tests
Side effects
Release note