config: Add index limit configuration #21192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-test |
|
/run-test |
bb7133
reviewed
Nov 23, 2020
|
LGTM |
|
PTAL @marsishandsome |
|
PTAL @wjhuang2016, @AilinKid |
AilinKid
reviewed
Nov 24, 2020
| @@ -644,6 +649,7 @@ var defaultConf = Config{ | |||
| EnableBatchDML: false, | |||
| CheckMb4ValueInUTF8: true, | |||
| MaxIndexLength: 3072, | |||
| IndexLimit: 64, | |||
There was a problem hiding this comment.
better use DefIndexLimit here
There was a problem hiding this comment.
We use DefIndexLimit as a constant. I think it is ok to use IndexLimit here, as other configuration items do not start with Def @AilinKid
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 24, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@b41sh merge failed. |
|
/run-all-tests |
|
/run-unit-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
What's Changed:
In order to be compatible with MySQL, we set up a table to have up to 64 indexes in PR 20353. But in some cases, we need more indexes, such as some test cases of TiSpark 1730.
In this PR, we add a configuration item that allows users to specify the index limit themselves.
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note