executor: load data statement shoule not be prepared #21188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
the
first-time-contributor
|
|
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
1 similar comment
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
7yyo
changed the title
jackysp
changed the title
-- add test case
jackysp
reviewed
Nov 23, 2020
executor/executor_test.go
Outdated
| @@ -5887,6 +5887,12 @@ func (s *testClusterTableSuite) TearDownSuite(c *C) { | |||
| s.testSuiteWithCliBase.TearDownSuite(c) | |||
| } | |||
|
|
|||
| func (s *testSuiteP1) TestPrepareLoadData(c *C) { | |||
| tk := testkit.NewTestKit(c, s.store) | |||
| tk.MustExec(`prepare stmt from "load data local infile '/tmp/load_data_test.csv' into table test";`) | |||
There was a problem hiding this comment.
It should return an error. You could use tk.ExecToErr
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 23, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21199 |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #21222 |
ti-srebot
added a commit
that referenced
this pull request
Nov 24, 2020
ti-srebot
added a commit
that referenced
this pull request
Nov 24, 2020
jackysp
pushed a commit
to qw4990/tidb
that referenced
this pull request
Nov 25, 2020
…ingcap#21199) Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiDBthrow unexpectederrorwhile executeloaddata stmtinprepare stmtProblem Summary:
The current
erroris：Load data: previous load data option isn't closed normalThe expected
erroris：This command is not supported in the prepared statement protocol yetWhat is changed and how it works?
What's Changed:
prepare
loaddatastmt will write logerrorErrUnsupportedPsPs.JDBCwill resend thetext protocol requestRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note
errorwhen preparing theloaddatastatement.