expression: fix type infer for tidb's builtin compare(least and greatest) #21150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
requested review from
qw4990 and
XuHuaiyu
and removed request for
a team
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Closed
breezewish
reviewed
Nov 23, 2020
types/field_type.go
Outdated
| @@ -1258,6 +1262,49 @@ var fieldTypeMergeRules = [fieldTypeNum][fieldTypeNum]byte{ | |||
| }, | |||
| } | |||
|
|
|||
| const ( | |||
| InvalidResult byte = 0 /** not valid for UDFs */ | |||
There was a problem hiding this comment.
Maybe you need to define a new type for these constants?
types/field_type.go
Outdated
| StringResult byte = 1 /** char * */ | ||
| RealResult byte = 2 /** double */ | ||
| IntResult byte = 3 /** long long */ | ||
| RowResult byte = 4 /** not valid for UDFs */ |
types/field_type.go
Outdated
| RealResult byte = 2 /** double */ | ||
| IntResult byte = 3 /** long long */ | ||
| RowResult byte = 4 /** not valid for UDFs */ | ||
| DecimalResult byte = 5 /** char *, to be converted to/from a decimal */ |
types/field_type.go
Outdated
| StringResult, StringResult, | ||
| // mysql.TypeBit mysql.TypeInvalid | ||
| IntResult, InvalidResult, | ||
| // Unused entries: <17>-<242> |
There was a problem hiding this comment.
In previous definitions, the matrix order is TypeBit, <16>-<244>, TypeJSON, ...
In this implementation, the order is TypeBit, TypeInvalid, <17>-<242>, TypeBool, TypeJSON
Array elements are no longer aligned. Will there be problems?
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
breezewish
reviewed
Nov 23, 2020
|
/cc @lzmhhh123 |
|
/reward 900 |
|
This PR's linked issue is not picked. |
|
/run-all-tests |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
@iosmanthus Should it be cherry-picked into release-3.0 and release-4.0? |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
@lzmhhh123 @breeswish PTAL |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
XuHuaiyu
reviewed
Dec 21, 2020
expression/builtin_compare.go
Outdated
|
|
||
| var temporalItem *types.FieldType | ||
| aggType.EvalType() | ||
| if types.ResultMergeType(aggType.Tp) == types.ETString { |
There was a problem hiding this comment.
we can check whether the ETType == ETDatetime || ETType == ETString || ... instead of using ResultMergeType here.
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
ti-srebot
previously approved these changes
Dec 21, 2020
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
…nto fix-least-and-greatest
|
/run-all-tests tidb-test=pr/1137 |
|
/run-unit-test |
lzmhhh123
approved these changes
Dec 22, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21924 |
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
Jan 27, 2021
…est) (pingcap#21150) Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
qw4990
added a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number:
close #17994
close #9765
Problem Summary:
What is changed and how it works?
What's Changed:
This pull request migrates some MySQL type merge rules to make TiDB's type infer rules more MySQL compatible.
How it Works:
This pull request port https://github.com/mysql/mysql-server/blob/ee4455a33b10f1b1886044322e4893f587b319ed/sql%2Fitem_func.cc#L3470 to infer the result type of
least/greatestRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note