planner, expression: fix a bug causes schema change after DML #21027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Are there any other similar parts needing |
I' am not sure. It's difficult to consider all the cases. |
|
lgtm |
|
@xiongjiwei, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack). |
|
There is no reward for this challenge pull request, so you can request a reward from @SunRunAway. |
1 similar comment
|
There is no reward for this challenge pull request, so you can request a reward from @SunRunAway. |
ti-srebot
approved these changes
Nov 13, 2020
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21050 |
ti-srebot
added a commit
that referenced
this pull request
Nov 17, 2020
#21050) Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #19701
Problem Summary:
schema change after DML
What is changed and how it works?
Copy the fieldType
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note