store/tikv: fix log of sendTxnHeartBeat #21017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
added
type/bugfix
|
LGTM |
sticnarf
reviewed
Nov 12, 2020
| @@ -874,7 +875,7 @@ func sendTxnHeartBeat(bo *Backoffer, store *tikvStore, primary []byte, startTS, | |||
| } | |||
| cmdResp := resp.Resp.(*pb.TxnHeartBeatResponse) | |||
| if keyErr := cmdResp.GetError(); keyErr != nil { | |||
| return 0, errors.Errorf("txn %d heartbeat fail, primary key = %v, err = %s", startTS, primary, keyErr.Abort) | |||
| return 0, errors.Errorf("txn %d heartbeat fail, primary key = %v, err = %s", startTS, hex.EncodeToString(primary), extractKeyErr(keyErr)) | |||
There was a problem hiding this comment.
Maybe it's better to use prettyWriteKey to print?
There was a problem hiding this comment.
I think we don't care what the key represents(a concrete table key or index key) in this case. Hex format is enough and easy for debug.
|
/lgtm |
ti-srebot
approved these changes
Nov 12, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/merge |
|
/run-all-tests |
|
@youjiali1995 merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #15654
Problem Summary:
Refine the log of sendTxnHeartBeat.
What is changed and how it works?
What's Changed:
Refine the log of sendTxnHeartBeat.
Related changes
Check List
Tests
Release note