tikv: add size limit to batch get cache #21015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-check_dev_2 |
jackysp
reviewed
Nov 12, 2020
| s.mu.cached[string(key)] = val | ||
| } | ||
|
|
||
| const cachedSizeLimit = 10 << 30 |
There was a problem hiding this comment.
We could change it to a const for
Line 965 in 9af236c
|
LGTM |
ti-srebot
approved these changes
Nov 18, 2020
tiancaiamao
approved these changes
Nov 18, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@bobotu merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21129 |
ti-srebot
added a commit
that referenced
this pull request
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19560
The internal cache used by
BatchGetneed a size limit, it is OK to randomly discard some entry in it.What is changed and how it works?
Add a size limit which equals to default
TxnTotalSizeLimit. We can delete some entry from it randomly when the limit is exceeded.Release note