Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix bug when parsing the slow logs if the logNum is small #20959

Merged
merged 9 commits into from
Nov 23, 2020
Merged

executor: fix bug when parsing the slow logs if the logNum is small #20959

merged 9 commits into from
Nov 23, 2020

Conversation

TszKitLo40
Copy link
Contributor

@TszKitLo40 TszKitLo40 commented Nov 10, 2020 •
edited by crazycs520
Loading

What problem does this PR solve?

Issue Number: close #20928

Problem Summary:

What is changed and how it works?

What's Changed:
fix bug when parsing the slow logs if the logNum is small
How it Work:
add judgment for checking whether a slow log has been parsed.

Check List

Tests

  • Unit test

Release note

  • Fix issue of the query result of slow_query maybe miss some rows.

@TszKitLo40 TszKitLo40 requested a review from a team as a code owner November 10, 2020 08:04
@TszKitLo40 TszKitLo40 requested review from XuHuaiyu and removed request for a team November 10, 2020 08:04
@jyz0309
Copy link
Contributor

jyz0309 commented Nov 10, 2020

LGTM, please add some release note

@github-actions github-actions bot added the sig/execution SIG execution label Nov 10, 2020
@TszKitLo40
Copy link
Contributor Author

TszKitLo40 commented Nov 10, 2020 •
edited
Loading

LGTM, please add some release note

It seems that the release note is not necessary.

@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

crazycs520
crazycs520 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2020
@crazycs520
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

@crazycs520 Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1

@jyz0309
Copy link
Contributor

jyz0309 commented Nov 12, 2020

@XuHuaiyu PTAL

crazycs520
crazycs520 previously approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2020
@pingcap pingcap deleted a comment from ti-srebot Nov 20, 2020
@pingcap pingcap deleted a comment from ti-srebot Nov 20, 2020
@crazycs520 crazycs520 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 20, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

@AilinKid PTAL

AilinKid
AilinKid reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 23, 2020
@crazycs520 crazycs520 merged commit ea3e4fa into pingcap:master Nov 23, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 23, 2020
@TszKitLo40 @ti-srebot
cherry pick pingcap#20959 to release-4.0
2c819e7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 23, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21211

ti-srebot added a commit that referenced this pull request Nov 27, 2020
@ti-srebot
executor: fix bug when parsing the slow logs if the logNum is small (#…
86582a3 
…20959) (#21211)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@crazycs520 crazycs520 crazycs520 left review comments

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some slow logs may be ignored in getBatchLog
6 participants
@TszKitLo40 @jyz0309 @zhouqiang-cl @crazycs520 @ti-srebot @AilinKid