Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix somes bugs related to the clustered index and the new collation #20934

Merged

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 9, 2020

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #20881 close #20856

Problem Summary:
If the common handle contains the string column which needs restored data, we should not decode them from the handle.

What is changed and how it works?

Skip decode column if it needs restored data.

Related changes

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner November 9, 2020 08:43
@wjhuang2016 wjhuang2016 requested review from SunRunAway and removed request for a team November 9, 2020 08:43
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@coocood
Copy link
Member

coocood commented Nov 9, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2020
ti-srebot
ti-srebot previously approved these changes Nov 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 9, 2020
@wjhuang2016
Copy link
Member Author

/run-all-tests

2 similar comments
@wjhuang2016
Copy link
Member Author

/run-all-tests

@wjhuang2016
Copy link
Member Author

/run-all-tests

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
coocood
coocood previously approved these changes Nov 12, 2020
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Copy link
Member Author

/merge

@ti-srebot
Copy link
Contributor

@wjhuang2016 Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@wjhuang2016 wjhuang2016 added the status/can-merge Indicates a PR has been approved by a committer. label Nov 12, 2020
@ti-srebot
Copy link
Contributor

@wjhuang2016 Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@wjhuang2016
Copy link
Member Author

/run-all-tests

@wjhuang2016
Copy link
Member Author

/run-all-tests

@wjhuang2016 wjhuang2016 merged commit ef57bdb into pingcap:master Nov 12, 2020
@wjhuang2016 wjhuang2016 deleted the fix_new_collation_clustered_index branch November 17, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
4 participants