server: check LOAD DATA is into a base table #20924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@nullnotnil The PR #20917 has fixed the break of pingcap/parser#1079 |
Thanks! I'll watch for this to merge, and then update this PR. |
|
@nullnotnil The PR #20917 has merged. |
added 4 commits
November 10, 2020 09:28
ti-srebot
previously approved these changes
Dec 3, 2020
ghost
dismissed
Closed
|
@tangenta, @wjhuang2016, @ti-srebot, PTAL. |
1 similar comment
|
@tangenta, @wjhuang2016, @ti-srebot, PTAL. |
|
@tangenta, @wjhuang2016, @ti-srebot, PTAL. |
wjhuang2016
approved these changes
Dec 10, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@nullnotnil merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21638 |
qw4990
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fixes #20880
Problem Summary:
What is changed and how it works?
What's Changed:
Before loading data using
LOAD DATA, a check if performed to make sure that the table is of type base table.How it Works:
I have a PR on pingcap/parser#1080 to add an explicity
IsBaseTable()function, which I think will be useful in other cases such as infoschema.Note: The error code is a generic one. TiDB does not allow insertable views (differing from MySQL), and MySQL does not support sequences.
Related changes
Check List
Tests
Side effects
Release note
LOAD DATAstatement can only load data into base tables.