expression: fix builtin IF truncation of type len #20743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
|
/run-all-tests |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
qw4990
reviewed
Nov 2, 2020
Closed
lzmhhh123
reviewed
Nov 17, 2020
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@nullnotnil merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@nullnotnil merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21144 |
ti-srebot
added a commit
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fixes #20730
Problem Summary:
When one of the values of the built-in function
ifis an expression, the type length is calculated incorrectly. This leads to values being truncated in user variables, which could lead to wrong results.What is changed and how it works?
What's Changed:
If the length is unknown (-1) the length of mysql.MaxRealWidth is returned instead. This is the behavior observed in MySQL.
Related changes
Check List
Tests
Side effects
Release note
IFfunction and user variables could lead to wrong results.