-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: support decode more types through tidb_decode_key() #20382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@tangenta merge failed. |
/merge |
/run-all-tests |
@tangenta merge failed. |
/merge |
/run-all-tests |
LGTM |
/merge |
/run-all-tests |
@tangenta merge failed. |
/run-unit-test |
What problem does this PR solve?
Problem Summary: Before this PR, it is not possible to use
tidb_decode_key()
to decode some column types likedatetime
ordecimal
because of the lack of table information.We can see that
'2020-01-01'
is decoded to1847955789872889856
, which is not expected.What is changed and how it works?
What's Changed:
tidb_decode_key()
is changed to JSON.tidb_decode_key()
may not idempotent anymore:Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
N/A
Release note