-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: add /debug/gogc
to set GOGC on the fly
#20247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-monitor-test |
Visit the grafana server at: http://172.16.5.5:32445, it will last for 5 hours |
jackysp
reviewed
Sep 27, 2020
jackysp
reviewed
Sep 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
ti-srebot
approved these changes
Sep 27, 2020
/merge |
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #20253 |
jackysp
pushed a commit
that referenced
this pull request
Sep 28, 2020
bobotu
pushed a commit
to bobotu/tidb
that referenced
this pull request
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Sometimes we need to adjust the GOGC to temporarily relieve memory pressure, so I have added an HTTP API to support this operation.
What is changed and how it works?
What's Changed:
Use
debug.SetGCPercent
to adjust GOGC for the next GC cycle, and updateTiDB-Runtime
dashboard to use the realGOGC
value.To make it easier to troubleshooting, I also added
GOGC
andMAXPROCS
to the output of/info
.Release note