*: collect index usage information from point get and dump them to KV #20126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label componet/statistics |
|
These labels are not found |
|
/label component/statistics |
|
/label sig/planner |
|
/cc @qw4990 |
github-actions
bot
added
component/config
sig/sql-infra
qw4990
reviewed
Oct 12, 2020
qw4990
reviewed
Oct 12, 2020
qw4990
reviewed
Oct 12, 2020
qw4990
reviewed
Oct 12, 2020
Co-authored-by: Yuanjia Zhang <qw4990@163.com>
ti-srebot
approved these changes
Oct 16, 2020
winoros
reviewed
Oct 16, 2020
| ```sql | ||
| create table SCHEMA_INDEX_USAGE ( | ||
| TABLE_SCHEMA varchar(64), | ||
| TABLE_NAME varchar(64), |
There was a problem hiding this comment.
We'd better store table id and index id?
The table name and index name can be changed by ddl stmt.
There was a problem hiding this comment.
I think name is more user-friendly than id. And there are two solutions to this problem.
- One is to handle the DDL of rename to modify the name in the table.
- And the other is to create a more user-friendly view based on this table.
I prefer the latter. If you agree, I'll modify it in next PR and write it in the document.
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@rebelice merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #19209
Problem Summary:
Collect index usage information from point get and dump them to KV.
This is a part of #19209 . And I'll collect index usage information from others in the following pr.
What is changed and how it works?
Proposal: Index usage information
What's Changed:
How it Works:
Related changes
Check List
Side effects
Release note