ddl: fix panic tidb-server doesn't release table lock (#19586) #20020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
zimulala
reviewed
Sep 17, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
ti-srebot
added
status/LGT2
|
/run-all-tests |
lzmhhh123
approved these changes
Sep 21, 2020
|
@lzmhhh123,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack). |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19586 to release-4.0
What problem does this PR solve?
Close #19240
When
tidb-serverbeenkilled -9(such as oom that killed by the system), the tidb-server won't release the held table locks, and thisdeadtable lock will never be released unless user useadmin cleanup table lockstatement.What is changed and how it works?
Add a background goroutine to periodic inspection the
deadlock.If the lock is held by the server that doesn't exist meta key (such as
DDLAllSchemaVersionsmeta key) in ETCD, we think the server is dead, so we can clean the locks that hold by the dead tidb-server.Why use
DDLAllSchemaVersionsmeta key instead ofServerInformationPathmeta key?Table lockimplementation with DDL, andDDLAllSchemaVersionsmeta key is a related DDL meta key.DDLAllSchemaVersionsTTL is 90s, butServerInformationPathTTL is 10 min. The TTL90sis much better for usage.Related changes
Check List
Tests
Side effects
Release note