Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expressions: Support push ROUND function to TiFlash (#19616) #19967

Merged
merged 4 commits into from
Sep 21, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19616 to release-4.0


Signed-off-by: leiysky leiysky@outlook.com

What problem does this PR solve?

Problem Summary:
Support ROUND function push to TiFlash.

What is changed and how it works?

What's Changed:

  • Enable the switcher to push ROUND to TiFlash

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test (sqllogic)

Release note

  • Support push ROUND function to TiFlash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@leiysky please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@lilinghai
Copy link
Contributor

/run-tics-test

@leiysky
Copy link
Contributor

leiysky commented Sep 15, 2020

@tangenta @SunRunAway PTAL

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20092
  • 19972

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20092
  • 19972

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@leiysky
Copy link
Contributor

leiysky commented Sep 21, 2020

/run-all-tests

@leiysky
Copy link
Contributor

leiysky commented Sep 21, 2020

/run-all-tests

@leiysky
Copy link
Contributor

leiysky commented Sep 21, 2020

/run-all-tests

@SunRunAway SunRunAway merged commit d56980b into pingcap:release-4.0 Sep 21, 2020
@SunRunAway SunRunAway deleted the release-4.0-ab00d5662867 branch September 21, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants