Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check constraint when alter enum/set type column #19806

Merged
merged 20 commits into from
Sep 17, 2020
Merged

ddl: check constraint when alter enum/set type column #19806

merged 20 commits into from
Sep 17, 2020

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #19804

Problem Summary:

What is changed and how it works?

  • check constraint for enum/set column type
  • check type compatible for set type

set type follow enum type behiver, do not allow change position of elements

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

  • fix an issue that alter enum/set type does not check constraint

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 4, 2020
@xiongjiwei xiongjiwei marked this pull request as ready for review September 4, 2020 14:55
@xiongjiwei xiongjiwei requested a review from a team as a code owner September 4, 2020 14:55
@xiongjiwei xiongjiwei requested review from qw4990 and removed request for a team September 4, 2020 14:55
wjhuang2016
wjhuang2016 reviewed Sep 5, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2020
xhebox
xhebox previously approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
ti-srebot
ti-srebot previously approved these changes Sep 7, 2020
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 7, 2020
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19879
  • 19671

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@zimulala
Copy link
Contributor

zimulala commented Sep 8, 2020

@xiongjiwei
Please fix the conflict.

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19844

@ti-srebot
Copy link
Contributor

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

@qw4990 need approve

@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@zimulala zimulala merged commit 73e03c7 into pingcap:master Sep 17, 2020
@xiongjiwei xiongjiwei deleted the bug-19804 branch September 17, 2020 01:52
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
@xiongjiwei @ti-srebot
cherry pick pingcap#19806 to release-3.0
817a983 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #20045

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
@xiongjiwei @ti-srebot
cherry pick pingcap#19806 to release-4.0
35f18fe 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20046

bb7133 pushed a commit that referenced this pull request Sep 17, 2020
@ti-srebot
ddl: check constraint when alter enum/set type column (#19806) (#20045)
86c6d16
zz-jason pushed a commit that referenced this pull request Oct 3, 2020
@ti-srebot
ddl: check constraint when alter enum/set type column (#19806) (#20046)
2a758ef
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

@xhebox xhebox xhebox left review comments

@zimulala zimulala zimulala left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alter set/enum type column does not check constraint
6 participants
@xiongjiwei @ti-srebot @zimulala @wjhuang2016 @qw4990 @xhebox