Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn:codec part for amend transaction with ddl #19659

Merged
merged 3 commits into from
Sep 1, 2020
Merged

txn:codec part for amend transaction with ddl #19659

merged 3 commits into from
Sep 1, 2020

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Sep 1, 2020

What problem does this PR solve?

What is changed and how it works?

Proposal: project

What's Changed:

  • The codec part for this project on release 4.0, Cherry-pick 18173 to release 4.0 branch

How it Works:

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • Part of the new feature commit transaction with concurrent DDLs.

@cfzjywxk cfzjywxk added require-LGT3 Indicates that the PR requires three LGTM. sig/transaction SIG:Transaction type/4.0-cherry-pick sig/sql-infra SIG: SQL Infra labels Sep 1, 2020
@cfzjywxk cfzjywxk changed the title Amend 4 0 codec part txn:codec part for amend transaction with ddl Sep 1, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Sep 1, 2020
@coocood
Copy link
Member

coocood commented Sep 1, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
jackysp
jackysp approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@jackysp
Copy link
Member

jackysp commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19465
  • 19559
  • 19601
  • 19611
  • 18443
  • 19541
  • 19276
  • 18119

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d890a8d into pingcap:release-4.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@lysu lysu Awaiting requested review from lysu

@coocood coocood Awaiting requested review from coocood

@zimulala zimulala Awaiting requested review from zimulala

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
require-LGT3 Indicates that the PR requires three LGTM. sig/execution SIG execution sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfzjywxk @coocood @jackysp @ti-srebot