Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: information_schema.tables add TIDB_PK_TYPE column for clustered index #19642

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

coocood
Copy link
Member

@coocood coocood commented Sep 1, 2020

What problem does this PR solve?

Makes it able to check if a table is clustered index by SQL.

What is changed and how it works?

information_schema.tables add TIDB_PK_TYPE column.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test

Release note

  • information_schema.tables add TIDB_PK_TYPE column.

@coocood coocood requested a review from a team as a code owner September 1, 2020 04:58
@coocood coocood requested review from qw4990 and removed request for a team September 1, 2020 04:58
@coocood coocood added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Sep 1, 2020
@coocood coocood requested review from bb7133 and tangenta September 1, 2020 05:00
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@bb7133
Copy link
Member

bb7133 commented Sep 1, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 1, 2020
@bb7133
Copy link
Member

bb7133 commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 82502cc into pingcap:master Sep 1, 2020
@coocood coocood deleted the add-pk-type branch September 2, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants