privilege: fix user change after show grants and add user existed check for show grants
#19568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
|
LGTM |
ti-srebot
approved these changes
Aug 28, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #19587 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18878
Problem Summary:
select user()returns different result after executeshow grantsshow grantscan show grants on not existed user.What is changed and how it works?
What's Changed:
auth.UserIdentitypointer on show grants.showGrantsto avoid executed on not existed user.How it Works:
Because of
SHOW GRANTSchange the content inauth.Identity, when executeSHOW GRANTS, it will change the host ofUserin session variable. The result ofselect user()will changed.Related changes
Check List
Tests
Side effects
Release note
SHOW GRANTScan show grants for not existed user.