Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix region table http response #19437

Merged
merged 4 commits into from
Aug 26, 2020
Merged

server: fix region table http response #19437

merged 4 commits into from
Aug 26, 2020

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Issue Number: close #11918
Problem Summary: /regions/{region} API outputs many memory database tables.

What is changed and how it works?

What's Changed: Skip memory dbs.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
start 1pd+1tikv+1tidb
curl http://127.0.0.1:10080/regions/2
check output

Release note

  • No release note

@disksing
server: fix region table http response
2013a4c 
Signed-off-by: disksing <i@disksing.com>
@disksing
fix test
0eb5cd8 
Signed-off-by: disksing <i@disksing.com>
wjhuang2016
wjhuang2016 reviewed Aug 26, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@disksing
Copy link
Contributor Author

/cc @zimulala

@ti-srebot ti-srebot requested a review from zimulala August 26, 2020 09:32
zimulala
zimulala approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 26, 2020
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18901

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit cf02975 into pingcap:master Aug 26, 2020
@disksing disksing deleted the fix-region-info branch August 27, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/regions/{region_id} API should not include performance tables
5 participants
@disksing @ti-srebot @zz-jason @zimulala @wjhuang2016