Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: correct the pre-commit soft link #19422

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Aug 25, 2020

As the https://stackoverflow.com/questions/4592838/symbolic-link-to-a-hook-in-git discuss,
ln -s hooks/pre-commit .git/hooks/pre-commit is not work.


This change is Reviewable

Release note

  • N/A

As the https://stackoverflow.com/questions/4592838/symbolic-link-to-a-hook-in-git discuss, 
`ln -s hooks/pre-commit .git/hooks/pre-commit` is not work.
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 25, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Aug 25, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Aug 25, 2020

@zz-jason zz-jason changed the title [hooks]: Update pre-commit hooks: correct the pre-commit soft link Oct 5, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 5, 2020
@zz-jason zz-jason requested a review from bb7133 October 5, 2020 06:20
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 9, 2020
@zz-jason
Copy link
Member

zz-jason commented Oct 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiekeyi98 merge failed.

@zz-jason
Copy link
Member

zz-jason commented Oct 9, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b03075c into pingcap:master Oct 9, 2020
@xiekeyi98 xiekeyi98 deleted the patch-3 branch October 9, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants