executor: use before statement snapshot for UnionScan #19276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-ddl-test |
|
LGTM |
|
LGTM |
ti-srebot
approved these changes
Aug 31, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-build_check_race |
|
@bobotu merge failed. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
bobotu
pushed a commit
to bobotu/tidb
that referenced
this pull request
Sep 7, 2020
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
This was referenced Sep 7, 2020
qw4990
pushed a commit
that referenced
this pull request
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19054
What is changed and how it works?
UnionScanwill read the statement internal buffer, it will cause data race when the reading table is being modified in the upper operator.If the
UnionScancan only read data at the snapshot before this statement start, we should only read from theMemBufferintikvTxn, not inTxnState.Check List
Tests
Release note