Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablecodec: fix check cluster index table on new collation #19181

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #19010

What is changed and how it works?

What's Changed: fix check cluster index table on new collation

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • none.

@lzmhhh123 lzmhhh123 requested a review from a team as a code owner August 13, 2020 09:52
@lzmhhh123 lzmhhh123 requested review from XuHuaiyu and coocood and removed request for a team August 13, 2020 09:52
@lzmhhh123 lzmhhh123 added sig/execution SIG execution type/bugfix This PR fixes a bug. labels Aug 13, 2020
@coocood
Copy link
Member

coocood commented Aug 13, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2020
@lzmhhh123
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lzmhhh123 merge failed.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #19181 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #19181   +/-   ##
===========================================
  Coverage   79.1299%   79.1299%           
===========================================
  Files           549        549           
  Lines        149238     149238           
===========================================
  Hits         118092     118092           
  Misses        21631      21631           
  Partials       9515       9515           

@lzmhhh123 lzmhhh123 merged commit baedc33 into pingcap:master Aug 13, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_panic_check_table_on_cluster_index branch August 13, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clustered index: index out of range [1] with length 1
4 participants