Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: support collecting RAID information to CLUSTER_HARDWARE #19171

Merged
merged 4 commits into from
Aug 26, 2020
Merged

telemetry: support collecting RAID information to CLUSTER_HARDWARE #19171

merged 4 commits into from
Aug 26, 2020

Conversation

motecshine
Copy link
Contributor

@motecshine motecshine commented Aug 13, 2020 •
edited
Loading

What is changed and how it works?

[root@tikv-0001 tidb]# lsblk
NAME    MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINT
vda     253:0    0    40G  0 disk  
└─vda1  253:1    0    40G  0 part  /
vdb     253:16   0 744.5G  0 disk  
└─md127   9:127  0   1.5T  0 raid0 /home/data1
vdc     253:32   0 744.5G  0 disk  
└─md127   9:127  0   1.5T  0 raid0 /home/data1

image

image

Related changes

  • PR to update telemetry/data_cluster_hardware.go/telemetry/data_cluster_hardware_test.go:

Release note

  • Fix INFORMATION_SCHEMA.CLUSTER_HARDWARE dose not have raid0 devices information

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Aug 13, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@motecshine
Copy link
Contributor Author

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Aug 14, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@motecshine
Copy link
Contributor Author

/rebuild

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #19171 into master will decrease coverage by 0.0803%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #19171        +/-   ##
================================================
- Coverage   79.1607%   79.0803%   -0.0804%     
================================================
  Files           549        549                
  Lines        149391     148779       -612     
================================================
- Hits         118259     117655       -604     
- Misses        21628      21629         +1     
+ Partials       9504       9495         -9

wjhuang2016
wjhuang2016 reviewed Aug 17, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@wjhuang2016
Copy link
Member

@crazycs520 PTAL

@motecshine
Copy link
Contributor Author

@crazycs520 PTAL

zz-jason
zz-jason approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 26, 2020
@zz-jason zz-jason changed the title Fix INFORMATION_SCHEMA.CLUSTER_HARDWARE dose not have raid0 devices information telemetry: support collecting RAID 0 information to CLUSTER_HARDWARE Aug 26, 2020
@zz-jason
Copy link
Member

@motecshine is it possible to collect other raid levels?

@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19433
  • 19217

@motecshine
Copy link
Contributor Author

is it possible to collect other raid levels?

yes, see mdadm tools,

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@motecshine merge failed.

@motecshine
Copy link
Contributor Author

motecshine commented Aug 26, 2020 •
edited
Loading 

[2020-08-26T02:08:05.524Z] time="2020-08-26T10:08:05+08:00" level=fatal msg="run test [insert_select] err: sql:insert into t1 values (1,1);: run \"insert into t1 values (1,1);\" at line 126 err Error 1146: Table 'test.t1' doesn't exist"

Maybe not because of the pull request, how can i fixed the problem @zz-jason

@zz-jason zz-jason changed the title telemetry: support collecting RAID 0 information to CLUSTER_HARDWARE telemetry: support collecting RAID information to CLUSTER_HARDWARE Aug 26, 2020
@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@motecshine merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19284

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d434365 into pingcap:master Aug 26, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
@motecshine @ti-srebot
cherry pick pingcap#19171 to release-4.0
ba63dd8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19457

zz-jason pushed a commit that referenced this pull request Sep 2, 2020
@ti-srebot
telemetry: support collecting RAID information to ... (#19171) (#19457)
9be2237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@zz-jason zz-jason zz-jason approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@motecshine @sre-bot @wjhuang2016 @zz-jason @ti-srebot