planner/core: fix partition selection on PointGet/BatchPointGet #19146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
requested review from
imtbkcat and
coocood
and removed request for
imtbkcat
|
LGTM |
ngaut
reviewed
Aug 12, 2020
| @@ -749,6 +764,16 @@ func tryPointGetPlan(ctx sessionctx.Context, selStmt *ast.SelectStmt) *PointGetP | |||
| return nil | |||
| } | |||
|
|
|||
| func partitionNameInSet(name model.CIStr, pnames []model.CIStr) bool { | |||
There was a problem hiding this comment.
Is there a performance issue when the partition count is large, For example: 65535.
There was a problem hiding this comment.
This name slice is not all the partitions of a table.
It's just the selected ones:
select * from t partition (p0,p1,p2) ...
A sane person would not write a SQL like this:
select * from t partition (p0,p1,p2....p65535) ...
SunRunAway
approved these changes
Aug 12, 2020
| @@ -429,3 +429,22 @@ func (s *testPointGetSuite) TestBatchPointGetPartition(c *C) { | |||
| tk.MustExec("delete from t where (a,b) in ((1,1),(2,2),(3,3),(4,4))") | |||
| tk.MustQuery("select * from t where (a, b) in ((1, 1), (2, 2), (3, 3), (4, 4))").Check(testkit.Rows()) | |||
| } | |||
|
|
|||
| func (s *testPointGetSuite) TestIssue19141(c *C) { | |||
There was a problem hiding this comment.
Should this case be ported back to master branch?
ti-srebot
approved these changes
Aug 12, 2020
|
/merge |
|
Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Aug 12, 2020
…cap#19146) * planner/core: fix partition selection on PointGet/BatchPointGet * make golint happy
tiancaiamao
added a commit
that referenced
this pull request
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19141
Problem Summary:
PointGet/BatchPointGet on the hash partition table does not take partition selection grammar into consideration.
What is changed and how it works?
What's Changed:
How it Works:
Related changes
This PR is on the 4.0 branch, I will file another one to fix the master.
Check List
Tests
Release note