transaction: fix union select for update race (#19006) #19022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/executor
priority/release-blocker
* transaction: fix LockKeys race * do not update delta for lock keys * fix more race * fix another race Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
coocood
force-pushed
the
release-4.0-b36393774455
branch
from
2013dd3 to
3cef071
Compare
|
LGTM |
|
LGTM |
ti-srebot
added
status/LGT2
lysu
approved these changes
Aug 6, 2020
ti-srebot
added
status/LGT3
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19006 to release-4.0
What problem does this PR solve?
union select for updatestatements are executed concurrently, soLockKeysis executed concurrently too, butLockKeysis not thread-safe, cause unexpected result.What is changed and how it works?
Lock the whole
LockKeysmethod instead of map access.Related changes
Check List
Tests
Release note