Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: skip region not found error in WaitScatterRegionFinish #18789

Merged
merged 2 commits into from
Jul 27, 2020
Merged

ddl: skip region not found error in WaitScatterRegionFinish #18789

merged 2 commits into from
Jul 27, 2020

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 26, 2020

What problem does this PR solve?

region not found error may end the waiting early. this error is irrelevant. we need to wait for all regions to be responded before ending the waiting.

What is changed and how it works?

check the error and skip it.

Check List

Tests

  • Manual test

the pre-split more stable.

Release note

  • ddl: Do not end the scatter wait early when receiving a PD error

@codecov
Copy link

codecov bot commented Jul 26, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@29178df). Click here to learn what that means.
The diff coverage is 0.0000%.

@@             Coverage Diff             @@
##             master     #18789   +/-   ##
===========================================
  Coverage          ?   79.1782%           
===========================================
  Files             ?        543           
  Lines             ?     146145           
  Branches          ?          0           
===========================================
  Hits              ?     115715           
  Misses            ?      21087           
  Partials          ?       9343

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 26, 2020
@coocood
Copy link
Member

coocood commented Jul 27, 2020

LGTM

@ti-srebot
Copy link
Contributor

@coocood,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: ddl(slack).

zimulala
zimulala approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
crazycs520
crazycs520 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 27, 2020
@coocood
Copy link
Member

coocood commented Jul 27, 2020

/merge

@ti-srebot
Copy link
Contributor

@coocood Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: ddl(slack).

@crazycs520 crazycs520 merged commit b249dc5 into pingcap:master Jul 27, 2020
@nolouch nolouch deleted the skip-pd-error branch July 27, 2020 04:59
@nolouch
Copy link
Member Author

nolouch commented Jul 27, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 27, 2020
@nolouch @ti-srebot
cherry pick pingcap#18789 to release-4.0
133a0b9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18796

zz-jason pushed a commit that referenced this pull request Sep 2, 2020
@ti-srebot
ddl: skip region not found error in WaitScatterReg ... (#18789) (#18796)
177c323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/tikv sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolouch @coocood @ti-srebot @zimulala @crazycs520