-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc_worker: add more tests for resolveLockPhysical #18715
gc_worker: add more tests for resolveLockPhysical #18715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
42e9a42
to
693a492
Compare
Codecov Report
@@ Coverage Diff @@
## master #18715 +/- ##
===========================================
Coverage 79.1785% 79.1785%
===========================================
Files 548 548
Lines 147958 147958
===========================================
Hits 117151 117151
Misses 21340 21340
Partials 9467 9467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@youjiali1995 merge failed. |
/merge |
/run-all-tests |
@youjiali1995 merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@youjiali1995 merge failed. |
/run-check_dev_2 |
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18974 |
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Problem Summary:
It's the last part of unit tests for green GC.
What is changed and how it works?
What's Changed:
Cover more cases.
Related changes
Check List
Tests
Side effects
Release note