Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: clustered index support primary index hint #18478

Merged
merged 1 commit into from
Jul 10, 2020
Merged

planner: clustered index support primary index hint #18478

merged 1 commit into from
Jul 10, 2020

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 10, 2020

What problem does this PR solve?

Clustered index return error if specify use index (PRIMARY)

What is changed and how it works?

Return tablePath if table is common handle table.

Check List

Tests

  • Unit test

Release note

  • no release note

@coocood coocood requested review from a team as code owners July 10, 2020 07:07
@coocood coocood requested review from qw4990 and hanfei1991 and removed request for a team July 10, 2020 07:07
@coocood coocood added the sig/planner SIG: Planner label Jul 10, 2020
jackysp
jackysp reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@jackysp, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:planner(slack).

lzmhhh123
lzmhhh123 reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

@lzmhhh123,Thanks for your review.

@ti-srebot
Copy link
Contributor

@jackysp, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:planner(slack).

@jackysp
Copy link
Member

jackysp commented Jul 10, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. You are not a committer or co-leader or leader for the related sigs:planner(slack).

zhangjinpeng87
zhangjinpeng87 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

@zhangjinpeng1987,Thanks for your review.

@zhangjinpeng87
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18439

@ti-srebot
Copy link
Contributor

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #18478 into master will decrease coverage by 0.1466%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master     #18478        +/-   ##
================================================
- Coverage   79.5849%   79.4382%   -0.1467%     
================================================
  Files           540        540                
  Lines        145990     144764      -1226     
================================================
- Hits         116186     114998      -1188     
+ Misses        20487      20486         -1     
+ Partials       9317       9280        -37

@ti-srebot ti-srebot merged commit 563f2c9 into pingcap:master Jul 10, 2020
@coocood coocood deleted the clustered-index-hint branch July 10, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@jackysp jackysp jackysp approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coocood @ti-srebot @jackysp @zhangjinpeng87 @lzmhhh123