support pushing bitwise operators and LogicXor down to kv #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_bit_ops_down Conflicts: plan/expr_to_pb.go �:q!
XuHuaiyu
changed the title
|
I split eval.go into five small files to classify different type of operators. |
XuHuaiyu
force-pushed
the
xhy/push_bit_ops_down
branch
from
ca90c6a to
fddb483
Compare
hanfei1991
reviewed
Oct 20, 2016
| if expr.GetTp() == tipb.ExprType_BitNeg { | ||
| var result types.Datum | ||
| if len(expr.Children) != 1 { | ||
| err := ErrInvalid.Gen("need 2 operands but got %d", len(expr.Children)) |
|
|
||
| func (e *Evaluator) evalIn(expr *tipb.Expr) (types.Datum, error) { | ||
| if len(expr.Children) != 2 { | ||
| return types.Datum{}, ErrInvalid.Gen("IN need 2 operand, got %d", len(expr.Children)) |
| return | ||
| } | ||
|
|
||
| // if any is not integer, we round the operands and then use uint64 to calculate. |
XuHuaiyu
force-pushed
the
xhy/push_bit_ops_down
branch
from
dde3894 to
561ad6d
Compare
hanfei1991
reviewed
Oct 20, 2016
| @@ -395,3 +395,207 @@ func ComputeIntDiv(a, b Datum) (d Datum, err error) { | |||
| d.SetInt64(iVal) | |||
| return d, nil | |||
| } | |||
|
|
|||
| // decimal2RoundUint convert a MyDecimal to a uint64 after rounding. | |||
| return | ||
| } | ||
|
|
||
| // if either is not integer, we round the operands and then use uint64 to calculate. |
| return d, nil | ||
| } | ||
|
|
||
| // ComputeLeftShift computes the result of a >> b. |
XuHuaiyu
changed the title
hanfei1991
reviewed
Oct 21, 2016
| if expr.GetTp() == tipb.ExprType_BitNeg { | ||
| var result types.Datum | ||
| if len(expr.Children) != 1 { | ||
| err := ErrInvalid.Gen("need 1 operands but got %d", len(expr.Children)) |
|
rest LGTM |
zimulala
reviewed
Oct 22, 2016
| return e.evalNot(expr) | ||
| case tipb.ExprType_In: | ||
| return e.evalIn(expr) | ||
| // data type. |
There was a problem hiding this comment.
s/data/Data or remove .
The same as line57, line62, line65, line69 and the same as some comments in plan_test.go
|
PTAL |
XuHuaiyu
changed the title
|
I'll rewrite this PR after another PRs have been merged. |
…h_bit_ops_down Conflicts: distsql/xeval/eval.go distsql/xeval/eval_compare_ops.go distsql/xeval/eval_logic_ops.go plan/expr_to_pb.go `:q! �:q!
XuHuaiyu
force-pushed
the
xhy/push_bit_ops_down
branch
from
0597580 to
a547d0d
Compare
XuHuaiyu
changed the title
|
PTAL @hanfei1991 @coocood @shenli @zimulala @tiancaiamao |
shenli
reviewed
Oct 26, 2016
| if expr.GetTp() == tipb.ExprType_BitNeg { | ||
| var result types.Datum | ||
| if len(expr.Children) != 1 { | ||
| err := ErrInvalid.Gen("need 1 operand but got %d", len(expr.Children)) |
There was a problem hiding this comment.
Add operator name in the error message.
|
@hanfei1991 PTAL |
XuHuaiyu
force-pushed
the
xhy/push_bit_ops_down
branch
from
3a1d2de to
5f8ee14
Compare
|
LGTM |
|
@coocood PTAL |
shenli
reviewed
Oct 26, 2016
| } | ||
| return types.ComputeBitNeg(a) | ||
| } | ||
| var result types.Datum |
There was a problem hiding this comment.
Move this to the beginning and remove line 24.
| return | ||
| } | ||
| // If either is not integer, we round the operands and then use uint64 to calculate. | ||
| x, err := a.ToDecimal() |
There was a problem hiding this comment.
Use a function to replace the following code block, then we could save a lot of works in ComputeXXX.
…h_bit_ops_down Conflicts: distsql/xeval/eval.go plan/expr_to_pb.go �:q!
|
PTAL @shenli |
shenli
reviewed
Oct 27, 2016
| return d, errors.Trace(err) | ||
| } | ||
|
|
||
| y, err := b.ToDecimal() |
There was a problem hiding this comment.
Use convertNonInt2RoundUint64 instead.
| return d, errors.Trace(err) | ||
| } | ||
|
|
||
| uintX, err := decimal2RoundUint(x) |
|
@shenli PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
PTAL @hanfei1991 @coocood @shenli @zimulala @tiancaiamao