Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: check valid UTF8 value for UTF8 column #1818

Merged
merged 4 commits into from
Oct 14, 2016
Merged

table: check valid UTF8 value for UTF8 column #1818

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70ee0c4
table: check valid UTF8 value for UTF8 column
coocood Oct 11, 2016
bafcd17
*: fix test case
coocood Oct 11, 2016
7c90b62
Merge branch 'master' into coocood/check-utf8-validity
zimulala Oct 14, 2016
3c9cea6
Merge branch 'master' into coocood/check-utf8-validity
coocood Oct 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
*: fix test case
  • Loading branch information
@coocood
coocood committed Oct 11, 2016
commit bafcd171d63c0d9b325bef7a1e4266595cbcd0b5
2 changes: 1 addition & 1 deletion table/tables/tables_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (ts *testSuite) TestBasic(c *C) {
// Test input invalid utf8 value.
_, err = tb.AddRecord(ctx, types.MakeDatums(3, []byte{255}))
c.Assert(terror.ErrorEqual(err, table.ErrInvalidUTF8Value), IsTrue)
touched := map[int]bool{2: true}
touched := map[int]bool{1: true}
err = tb.UpdateRecord(ctx, 1, types.MakeDatums(1, "abc"), types.MakeDatums(1, []byte{255}), touched)
c.Assert(terror.ErrorEqual(err, table.ErrInvalidUTF8Value), IsTrue)

Expand Down