Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: enable green GC by default #18167

Merged
merged 6 commits into from
Jun 27, 2020

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Problem Summary:
Green GC will be released in v4.0.3.

What is changed and how it works?

What's Changed:
Enable green GC by default and make the config public.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: coming soon.
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • Enable green GC by default.

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@youjiali1995 merge failed.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #18167 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18167   +/-   ##
===========================================
  Coverage   79.5140%   79.5140%           
===========================================
  Files           535        535           
  Lines        144338     144338           
===========================================
  Hits         114769     114769           
  Misses        20309      20309           
  Partials       9260       9260           

@cfzjywxk
Copy link
Contributor

@youjiali1995 merge failed.

Seems unrelated fail...

[2020-06-22T11:36:07.446Z] ==================

[2020-06-22T11:36:07.446Z] WARNING: DATA RACE

[2020-06-22T11:36:07.446Z] Write at 0x00c02553ca68 by goroutine 100:

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:135 +0x148b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:130 +0x114c

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:69 +0x4bf

[2020-06-22T11:36:07.446Z]   runtime.call32()

[2020-06-22T11:36:07.446Z]       /usr/local/go/src/runtime/asm_amd64.s:539 +0x3a

[2020-06-22T11:36:07.446Z]   reflect.Value.Call()

[2020-06-22T11:36:07.446Z]       /usr/local/go/src/reflect/value.go:321 +0xd3

[2020-06-22T11:36:07.446Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0x9aa

[2020-06-22T11:36:07.446Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x113

[2020-06-22T11:36:07.446Z] 

[2020-06-22T11:36:07.446Z] Previous read at 0x00c02553ca68 by goroutine 384:

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange.func1()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:95 +0x104

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*TestDDLCallback).OnJobUpdated()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/callback_test.go:72 +0x200

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*TestDDLCallback).OnJobUpdated()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/callback_test.go:66 +0x50

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.446Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.446Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue.func1()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:466 +0x50a

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/kv.RunInNewTxn()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/kv/txn.go:47 +0x110

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:434 +0x19b

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*worker).handleDDLJobQueue()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:511 +0x250

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*worker).start()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_worker.go:155 +0x465

[2020-06-22T11:36:07.447Z] 

[2020-06-22T11:36:07.447Z] Goroutine 100 (running) created at:

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).forkCall()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4a3

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).forkTest()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1b9

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).doRun()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x13a

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0xf7

[2020-06-22T11:36:07.447Z] 

[2020-06-22T11:36:07.447Z] Goroutine 384 (running) created at:

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*ddl).Start()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl.go:338 +0xaf3

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.testNewDDLAndStart()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/ddl_test.go:112 +0x89

[2020-06-22T11:36:07.447Z]   github.com/pingcap/tidb/ddl.(*testIndexChangeSuite).TestIndexChange()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/index_change_test.go:55 +0x11d

[2020-06-22T11:36:07.447Z]   runtime.call32()

[2020-06-22T11:36:07.447Z]       /usr/local/go/src/runtime/asm_amd64.s:539 +0x3a

[2020-06-22T11:36:07.447Z]   reflect.Value.Call()

[2020-06-22T11:36:07.447Z]       /usr/local/go/src/reflect/value.go:321 +0xd3

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0x9aa

[2020-06-22T11:36:07.447Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()

[2020-06-22T11:36:07.447Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x113

[2020-06-22T11:36:07.447Z] ==================

@youjiali1995
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18188

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@youjiali1995 merge failed.

@youjiali1995
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Jun 24, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Jun 24, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@youjiali1995 merge failed.

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor

@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:transaction(slack).

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test bot

@AndreMouche AndreMouche dismissed their stale review June 27, 2020 08:44

cancel review to test bot

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:transaction(slack).

@jackysp
Copy link
Member

jackysp commented Jun 27, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 43d7b0e into pingcap:master Jun 27, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18223

@youjiali1995 youjiali1995 deleted the enable-green-gc-by-default branch June 29, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants