-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc_worker: enable green GC by default #18167
gc_worker: enable green GC by default #18167
Conversation
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@youjiali1995 merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #18167 +/- ##
===========================================
Coverage 79.5140% 79.5140%
===========================================
Files 535 535
Lines 144338 144338
===========================================
Hits 114769 114769
Misses 20309 20309
Partials 9260 9260 |
Seems unrelated fail...
|
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@youjiali1995 merge failed. |
/merge |
/run-all-tests |
/merge |
/run-all-tests |
/merge |
/run-all-tests |
@youjiali1995 merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:transaction(slack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:transaction(slack). |
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18223 |
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Problem Summary:
Green GC will be released in v4.0.3.
What is changed and how it works?
What's Changed:
Enable green GC by default and make the config public.
Related changes
pingcap/docs
/pingcap/docs-cn
: coming soon.Check List
Tests
Side effects
Release note