executor: set time zone offset in tipb.SelectRequest.
#1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time zone offset will be used by TiKV to compare timestamp type.
zimulala
reviewed
Oct 11, 2016
| @@ -806,3 +810,9 @@ func (e *XSelectTableExec) Next() (*Row, error) { | |||
| func (e *XSelectTableExec) Fields() []*ast.ResultField { | |||
| return nil | |||
| } | |||
|
|
|||
| // timeZoneOffset return local time zone offset in seconds. | |||
shenli
reviewed
Oct 11, 2016
| @@ -511,6 +512,7 @@ func (e *XSelectIndexExec) fetchHandles(idxResult distsql.SelectResult, ch chan< | |||
| func (e *XSelectIndexExec) doIndexRequest() (distsql.SelectResult, error) { | |||
| selIdxReq := new(tipb.SelectRequest) | |||
| selIdxReq.StartTs = e.startTS | |||
| selIdxReq.TimeZoneOffset = proto.Int64(timeZoneOffset()) | |||
There was a problem hiding this comment.
Why not use gogo nullable=false?
There was a problem hiding this comment.
Forgot to do that.
We can fix this the next time we need to update tipb.
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time zone offset will be used by TiKV to compare timestamp type.